Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: added network_id to google_compute_network #12504

Merged
merged 2 commits into from
Dec 16, 2024
Merged

compute: added network_id to google_compute_network #12504

merged 2 commits into from
Dec 16, 2024

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Dec 5, 2024 •
edited by shuyama1
Loading

Add network_id to google_compute_network.

It's an integer, not a string, and follows the expected convention for naming.

This adds a note deprecating numeric_id (to be potentially removed at some later date), which will have the same value, but as a string.

Part of terraform-provider-google#20530

See also #12351 and #12339, in particular this comment, this comment, and this discussion

Let me know if you want me to break this up into two separate release notes.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `network_id` (integer) to `google_compute_network` resource and data source

compute: deprecated `numeric_id` (string) field in `google_compute_network` resource. Use the new `network_id` (integer)  field instead

@github-actions github-actions bot requested a review from shuyama1 December 5, 2024 21:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 5, 2024
@wyardley wyardley force-pushed the wyardley/issues_20530 branch from 07b1565 to 961479b Compare December 5, 2024 21:55
@wyardley
Copy link
Contributor Author

wyardley commented Dec 5, 2024

@rileykarson FYI. I think this is what you had in mind, right?

@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1071
Passed tests: 997
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@wyardley
compute: add network_id to google_compute_network
f88bff7 
Add `network_id` to `google_compute_network`. It's an integer, not a
string, and follows the expected convention for naming.

This adds a note deprecating `numeric_id` (to be potentially removed at
some later date), which will have the same value, but as a string.

Part of terraform-provider-google#20530
@wyardley
Address code review feedback
7d51257
@wyardley wyardley force-pushed the wyardley/issues_20530 branch from 961479b to 7d51257 Compare December 9, 2024 05:51
@github-actions github-actions bot requested a review from shuyama1 December 9, 2024 05:52
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 36 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 36 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1073
Passed tests: 999
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@github-actions GitHub Actions
Copy link

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1
shuyama1 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuyama1 shuyama1 merged commit 219edef into GoogleCloudPlatform:main Dec 16, 2024
17 checks passed
This was referenced Dec 16, 2024
Merged
Merged
Merged
cesteve pushed a commit to cesteve/magic-modules that referenced this pull request Dec 17, 2024
@wyardley @cesteve
compute: added network_id to google_compute_network (GoogleCloudP…
0929b55 
…latform#12504)
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@wyardley @amanMahendroo
compute: added network_id to google_compute_network (GoogleCloudP…
d16c33e 
…latform#12504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
service/compute-vpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyardley @modular-magician @shuyama1